RFR: 8354920: SA core file support on Linux only prints error messages when debug logging is enabled [v3]

Chris Plummer cjplummer at openjdk.org
Tue Apr 22 22:04:41 UTC 2025


On Tue, 22 Apr 2025 21:29:01 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Currently if loading a core file fails, the diagnostic information provided on different systems is different; on MacOS we produce an error message, while on Linux we only print information if debug logging is enabled.
>> 
>> This PR adds some new messages on Linux to match MacOSX, and changes some of the diagnostic output to error level instead of debug. Additionally, if opening the core or the exe file fails, the system error message (strerror) is printed.
>> 
>> Tier1-3 testing clean.
>
> Daniel Jeliński has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Report Pgrab errors in exception message
>  - Remove odd double space

Looks good. Thanks for all the added cleanup.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24722#pullrequestreview-2785487091


More information about the serviceability-dev mailing list