RFR: 8355221: Get rid of unnecessary override of JDIBase.breakpointForCommunication in nsk/jdi tests

Chris Plummer cjplummer at openjdk.org
Wed Apr 23 05:29:17 UTC 2025


The following tests all override the JDIBase.breakpointForCommunication() method, but no longer need too:

vmTestbase/nsk/jdi/ClassPrepareRequest/addClassExclusionFilter/filter003.java
vmTestbase/nsk/jdi/ClassPrepareRequest/addClassFilter_rt/filter_rt002.java
vmTestbase/nsk/jdi/ClassPrepareRequest/addClassFilter_s/filter_s002.java
vmTestbase/nsk/jdi/EventRequestManager/classPrepareRequests/clsprepreq002.java
vmTestbase/nsk/jdi/EventRequestManager/methodExitRequests/methexitreq002.java
vmTestbase/nsk/jdi/MethodEntryRequest/addClassExclusionFilter/filter002.java
vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter002.java

The override was to fix [JDK-8203809](https://bugs.openjdk.org/browse/JDK-8203809). It filters out unexpected events due to system threads (namely Graal java compiler threads). However, there is now a JDIBase.breakpointForCommunication() version that does the same, so the override can be removed. The new version takes the debuggeeName argument that the override versions currently use to filter events based on it.

-------------

Commit messages:
 - Remove unneeded breakpointForCommunication() override.

Changes: https://git.openjdk.org/jdk/pull/24813/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24813&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8355221
  Stats: 176 lines in 7 files changed: 0 ins; 169 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/24813.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24813/head:pull/24813

PR: https://git.openjdk.org/jdk/pull/24813


More information about the serviceability-dev mailing list