RFR: 8355211: nsk/jdi/EventRequest/disable/disable001.java should use JDIBase superclass [v2]

Chris Plummer cjplummer at openjdk.org
Wed Apr 23 21:12:24 UTC 2025


On Wed, 23 Apr 2025 20:01:00 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequest/disable/disable001.java line 250:
> 
>> 248:             setupBreakpointForCommunication(debuggeeClass);
>> 249:         bpRequest.disable();
>> 250:         bpRequest.setSuspendPolicy(EventRequest.SUSPEND_ALL);
> 
> Could you please add a comment that setupBreakpointForCommunication creates request with SUSPEND_EVENT_THREAD policy, need to change it to SUSPEND_ALL

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24811#discussion_r2056875088


More information about the serviceability-dev mailing list