RFR: 8355221: Get rid of unnecessary override of JDIBase.breakpointForCommunication in nsk/jdi tests

Abdelhak Zaaim duke at openjdk.org
Wed Apr 23 21:16:46 UTC 2025


On Wed, 23 Apr 2025 05:24:50 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> The following tests all override the JDIBase.breakpointForCommunication() method, but no longer need too:
> 
> vmTestbase/nsk/jdi/ClassPrepareRequest/addClassExclusionFilter/filter003.java
> vmTestbase/nsk/jdi/ClassPrepareRequest/addClassFilter_rt/filter_rt002.java
> vmTestbase/nsk/jdi/ClassPrepareRequest/addClassFilter_s/filter_s002.java
> vmTestbase/nsk/jdi/EventRequestManager/classPrepareRequests/clsprepreq002.java
> vmTestbase/nsk/jdi/EventRequestManager/methodExitRequests/methexitreq002.java
> vmTestbase/nsk/jdi/MethodEntryRequest/addClassExclusionFilter/filter002.java
> vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter002.java
> 
> The override was to fix [JDK-8203809](https://bugs.openjdk.org/browse/JDK-8203809). It filters out unexpected events due to system threads (namely Graal java compiler threads). However, there is now a JDIBase.breakpointForCommunication() version that does the same, so the override can be removed. The new version takes the debuggeeName argument that the override versions currently use to filter events based on it.

Marked as reviewed by abdelhak-zaaim at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24813#pullrequestreview-2788698876


More information about the serviceability-dev mailing list