RFR: 8355453: nsk.share.jdi.Debugee.waitingEvent() does not timeout properly
Alex Menkov
amenkov at openjdk.org
Thu Apr 24 23:05:55 UTC 2025
On Thu, 24 Apr 2025 05:28:09 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
> nsk.share.jdi.Debugee.waitingEvent() takes a timeout argument. However, if the call to EventQueue.remove() times out and returns null, waitingEvent() just keep on retrying. The logic is incorrect for a null result. It should immediately throw an exception. The retry path is only meant for filtering out other events, and it updates "timeLeft' before retrying to avoid endlessly repeating the loop.
>
> Tested by running all of nsk/jdi locally on linux-x64-debug
Marked as reviewed by amenkov (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24839#pullrequestreview-2792696947
More information about the serviceability-dev
mailing list