RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Apr 25 02:39:53 UTC 2025
On Thu, 24 Apr 2025 19:30:22 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> This issue was hard to reproduce or had stopped happening, but was likely a failure to capture the main arguments from a monitored process, caused by slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most likely the same issue and increasing ARGS_ATTEMPTS has been seen to resolve it.
>>
>> While updating the test, fix the very verbose logging: it doesn't need to log, every second, how many nanos it has waited.
>> This has made logs from timeouts hardly usable as they are truncated and may miss critical info. Also, group the "tunable" constants together.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>
> Less unnecessary logging of expected exceptions
The fix looks reasonable.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24843#pullrequestreview-2792878582
More information about the serviceability-dev
mailing list