RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v3]

[Chris Plummer]

On Fri, 25 Apr 2025 12:38:27 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> This issue was hard to reproduce or had stopped happening, but was likely a failure to capture the main arguments from a monitored process, caused by slow startups e.g. -Xcomp.  Recent failures seen in Graal testing are most likely the same issue and increasing ARGS_ATTEMPTS has been seen to resolve it.
>> 
>> While updating the test, fix the very verbose logging: it doesn't need to log, every second, how many nanos it has waited.
>> This has made logs from timeouts hardly usable as they are truncated and may miss critical info.  Also, group the "tunable" constants together.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   REMOVE_TIMEOUT_SECONDS

test/jdk/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java line 78:

> 76:     private static final int PROCESS_COUNT = 10;
> 77:     private static final int ARGS_ATTEMPTS = 5;
> 78:     private static final int REMOVE_TIMEOUT_SECONDS = 300;

I'm still not convinced we need a large timeout here. The default timeout is 120 seconds, so jtreg will time out the test before waitForRemoval() times out itself.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24843#discussion_r2060546385