RFR: 8355569: Some nsk/jdi tests can glean the "main" thread by using the ClassPrepareEvent for the debuggee main class [v4]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Apr 30 22:45:48 UTC 2025
On Wed, 30 Apr 2025 21:07:01 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> As part of the work for [JDK-8353955](https://bugs.openjdk.org/browse/JDK-8353955) I am reducing the number of tests that need to be run with includevirtualhreads=y due to using JDI to lookup threads in the debuggee. There are many tests that lookup the "main" thread. They can instead glean the "main" thread from the ClassPrepareEvent for the debuggee main class. Some tests already wait for this ClassPrepareEvent, and can take advantage of it. Most do not, but can be made to do so. The easiest way to do this for many of the tests is to wait for the event in Debuggee.prepareDebuggee() after having called Debuggee.bindToDebuggee(). For tests that don't call Debuggee.prepareDebuggee(), waiting for the ClassPrepareEvent was added after the bind. This doesn't seem to have any ill affect on the tests.
>>
>> Tested by running all nsk/jdi tests, including all tier2, tier3, and tier5 nsk/jdi testing.
>
> Chris Plummer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - Merge
> - found one more test to fix
> - glean main thread from ClassPrepareEvent
> - update copyrights
> - Get debuggee main thread from ClassPrepareEvent for debuggee main class.
Marked as reviewed by sspitsyn (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24867#pullrequestreview-2808720702
More information about the serviceability-dev
mailing list