RFR: 8364312: debug agent should set FD_CLOEXEC flag rather than explicitly closing every open file [v2]
Guanqiang Han
ghan at openjdk.org
Tue Aug 5 10:35:07 UTC 2025
On Mon, 4 Aug 2025 13:57:19 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Guanqiang Han has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update exec_md.c
>>
>> correct an compilation error
>
> I added some comments. Testing needs to be done on all of the following
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi
> test/hotspot/jtreg/vmTestbase/nsk/jdb
> test/hotspot/jtreg/vmTestbase/nsk/jdwp
> test/jdk/com/sun/jdi
>
> Are you able to test all supported platforms (linux-x64, linux-aarch64, macosx-x64, macosx-aarch64, windows-x64)? If you can't, I'll download your patch and run the changes through our CI.
Hi @plummercj , thank you for the review and comments. I've updated the PR and will run the required tests on linux-x64. I currently don't have access to the other platforms (linux-aarch64, macosx-x64, macosx-aarch64, windows-x64), so I'd appreciate it if you could help run the patch through your CI .
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26568#issuecomment-3154639450
More information about the serviceability-dev
mailing list