RFR: 8364312: debug agent should set FD_CLOEXEC flag rather than explicitly closing every open file [v3]

[Guanqiang Han]

On Tue, 5 Aug 2025 20:33:04 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Guanqiang Han has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - a small fix
>>  - Merge remote-tracking branch 'upstream/master' into 8364312
>>  - Update exec_md.c
>>    
>>    correct an compilation error
>>  - 8364312: debug agent should set FD_CLOEXEC flag rather than explicitly closing every open file
>>    
>>    Create a new function that marks all file descriptors found in /proc/self/fd with the FD_CLOEXEC flag to ensure they are automatically closed upon execution of a new program via exec().
>
> Looks good and passes all my CI testing. Note I can't test AIX.

Hi @plummercj , thanks again for your help.

Just to confirm — does your CI testing include linux-x64? I ran the tests locally on that platform, and some of them failed with timeout errors, which might be related to my machine’s performance.

Also, since this PR is marked with /reviewers 2, should I look for another reviewer to help meet the integration requirements? Do you happen to know someone familiar with this area who might be a good candidate?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26568#issuecomment-3157059596