RFR: 8364312: debug agent should set FD_CLOEXEC flag rather than explicitly closing every open file [v3]
Guanqiang Han
ghan at openjdk.org
Wed Aug 6 15:05:06 UTC 2025
On Wed, 6 Aug 2025 13:07:35 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Hi @plummercj , thanks again for your help.
>>
>> Just to confirm — does your CI testing include linux-x64? I ran the tests locally on that platform, and some of them failed with timeout errors, which might be related to my machine’s performance.
>>
>> Also, since this PR is marked with /reviewers 2, should I look for another reviewer to help meet the integration requirements? Do you happen to know someone familiar with this area who might be a good candidate?
>
>> Just to confirm — does your CI testing include linux-x64? I ran the tests locally on that platform, and some of them failed with timeout errors, which might be related to my machine’s performance.
>
> I tested linux-x64-debug. If you are seeing timeouts, you should do test runs without any of your changes to see whether or not your changes introduced the timeouts.
Hi @plummercj and @kevinjwalls
Thank you both for your reviews and approvals — much appreciated!
Please sponsor this change.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26568#issuecomment-3160544303
More information about the serviceability-dev
mailing list