RFR: 8364973: Add JVMTI stress testing mode [v3]
Leonid Mesnik
lmesnik at openjdk.org
Mon Aug 11 19:35:13 UTC 2025
On Mon, 11 Aug 2025 09:35:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixed makefiles
>
> make/RunTests.gmk line 881:
>
>> 879:
>> 880: ifneq ($$(JTREG_JVMTI_STRESS_AGENT), )
>> 881: AGENT := $$(LIBRARY_PREFIX)JvmtiStressAgent$$(SHARED_LIBRARY_SUFFIX)=$$(JTREG_JVMTI_STRESS_AGENT)
>
> I don't understand the usage scenario here. Are you supposed to run this like `make test JTREG=JVMTI_STRESS_AGENT=true`? If so, this will result in `-javaoption:'-agentpath:<test-image>/hotspot/jtreg/native/libJvmtiStressAgent.so=true` being sent to jtreg, and that looks sus.
>
> Or how should this be used?
>
> In fact, this option should be described in testing.md.
This is a jtreg agent options, I use it like
JTREG_JVMTI_STRESS_AGENT=debugger=false
or
JTREG_JVMTI_STRESS_AGENT=debugger=true,verbose
Any of options enable jvmti agent and parsed by it.
I don't want to add 2 options, for hits. The JTREG_JVMTI_STRESS_AGENT=false doesn't make any sense.
The options are defined by stress agent while makefile just propagate them to the agent.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2267818671
More information about the serviceability-dev
mailing list