RFR: 8372098: Move AccessFlags to InstanceKlass [v5]

[Dean Long]

On Mon, 1 Dec 2025 15:02:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> ArrayKlass doesn't set AccessFlags so don't look for them there.  See CR for details.
>> Fixed SA and jvmci.  @iwanowww Can you check that I changed C2 correctly (we talked about this in August).
>> Tested with tier1-4.  5-7 in progress.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added a comment for checking interface guard after array guard.

Looks good.

src/hotspot/share/opto/library_call.cpp line 4104:

> 4102:       phi->add_req(makecon(TypeInstPtr::make(env()->Object_klass()->java_mirror())));
> 4103:     }
> 4104:     // Check for interface after array since this checks AccessFlags offset into InstanceKlass.

In other words, we are accessing subtype-specific information, so we need to determine the subtype first.

-------------

Marked as reviewed by dlong (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28371#pullrequestreview-3527269001
PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2578897794