RFR: 8371194: serviceability/sa/TestJhsdbJstackMixedWithXComp.java failing [v3]
Chris Plummer
cjplummer at openjdk.org
Mon Dec 1 22:26:53 UTC 2025
On Thu, 20 Nov 2025 01:25:45 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>> We've fixed mixed mode jstack for the debuggee running with `-Xcomp` in [JDK-8370176](https://bugs.openjdk.org/browse/JDK-8370176), but it was not enough. We need to handle like unifying `CFrame` and `Frame` in stack unwinding as possible, and need to change how to get caller SP/FP from stack.
>>
>> This PR works fine on both Linux AMD64 and Linux AArch64. All of `hotspot/jtreg/serviceability/sa` tests have been passed on both platforms.
>>
>> Big thanks to @pchilano for your help!
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix for macOS
Overall this looks good. I made one very minor request for a comment fix. Thanks for all your efforts here1
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java line 80:
> 78: private BsdCDebugger cdbg;
> 79:
> 80: // loadObjectList are filled by attach0 method
Suggestion:
// loadObjectList is filled by attach0 method
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28284#pullrequestreview-3527245704
PR Review Comment: https://git.openjdk.org/jdk/pull/28284#discussion_r2578883005
More information about the serviceability-dev
mailing list