RFR: 8364343: Virtual Thread transition management needs to be independent of JVM TI [v11]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Tue Dec 2 20:42:30 UTC 2025
On Tue, 2 Dec 2025 20:28:22 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
> Yes, this is a great work!
>
Thanks for the review Serguei!
> src/hotspot/share/runtime/mountUnmountDisabler.cpp line 87:
>
>> 85: }
>> 86: DEBUG_ONLY(bool is_virtual = java_lang_VirtualThread::is_instance(_current->jvmti_vthread()));
>> 87: assert((_is_mount && is_virtual) || (!_is_mount && !is_virtual), "wrong identity");
>
> Nit: Thank you for update! This check can be simplified with:
>
> assert(_is_mount == is_virtual), "wrong identity");
>
> But it becomes more obscure though. Feel free to ignore this comment.
I applied the suggestion, it reads well to me.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28361#issuecomment-3603874550
PR Review Comment: https://git.openjdk.org/jdk/pull/28361#discussion_r2582710357
More information about the serviceability-dev
mailing list