RFR: 8362083: JDI VirtualMachine/dispose/dispose001 failed with FATAL ERROR in native method: JDWP cannot set thread local storage, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)

[Leonid Mesnik]

On Thu, 4 Dec 2025 04:06:53 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> During the debugger disconnect we free all ThreadNodes for vthreads. Part of doing this includes calling JVMTI SetThreadLocalStorage(thread, NULL). It's possible that after the disconnect process has already started the VM starts to exit (resulting in a VMDeath event). Once this happens SetThreadLocalStorage will start to return JVMTI_ERROR_WRONG_PHASE. We should ignore this error rather than having it result in an fatal error for the debug agent.
> 
> Tested with tier1, all tier5 svc testing, and ran vmTestbase/nsk/jdi 10 times on linux-aarch64-debug, which is the only platform that has seen this failure so far.

Changes requested by lmesnik (Reviewer).

src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 173:

> 171:         }
> 172:     }
> 173:     if (error == JVMTI_ERROR_WRONG_PHASE && gdata->vmDead && isVThread(thread)) {

Shouldn't be check for any daemon threads and not only virtual?

-------------

PR Review: https://git.openjdk.org/jdk/pull/28653#pullrequestreview-3537964272
PR Review Comment: https://git.openjdk.org/jdk/pull/28653#discussion_r2587444390