RFR: 8371502: serviceability/jvmti/vthread/ThreadListStackTracesTest/ThreadListStackTracesTest.java failing [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Dec 12 04:02:51 UTC 2025
On Thu, 11 Dec 2025 02:36:12 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> This fixes the test which is unreliable and fails intermittently from time to time.
>> The test was failing in the method `checkReentrantLock()` when comparing the expected state with result from `vt.getState()`. The issue is that the call to `ThreadListStackTracesTest.reentrantLock.lock()` in a `ReentrantLockTestTask` can reach waiting state on some class loading but not on the ReentrantLock. Please see the first comment for test sources details.
>> The fix is to add a big enough sleep before call to the checkStates().
>>
>> Testing:
>> - submitted about thousands of mach5 runs of the `ThreadListStackTracesTest` test runs before and after the fix
>> - TBD: submit mach5 tiers 1-3 to be completely safe
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>
> review: use ReentrantLock.hasQueuedThread()
Thank you for review, Alex!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28734#issuecomment-3644806138
More information about the serviceability-dev
mailing list