RFR: 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests [v2]
SendaoYan
syan at openjdk.org
Mon Dec 15 06:18:35 UTC 2025
> Hi all,
>
> The DockerTestUtils.RETAIN_IMAGE_AFTER_TEST variable which read the property from "jdk.test.docker.retain.image" do not work for some of the docker tests, such as jdk/internal/platform/docker/TestDockerCpuMetrics.java, only works for some of the docker tests, such as jdk/internal/platform/docker/TestPidsLimit.java.
>
> This PR read the DockerTestUtils.RETAIN_IMAGE_AFTER_TEST inside function removeDockerImage instead of before all the fucntion removeDockerImage. This will make all the docker tests receive the property jdk.test.docker.retain.image.
>
> Change has been verified locally on linux-x64 by run the all touched tests.
SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
Remove extra ident
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28208/files
- new: https://git.openjdk.org/jdk/pull/28208/files/75356d0e..5e39c8f3
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28208&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28208&range=00-01
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/28208.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28208/head:pull/28208
PR: https://git.openjdk.org/jdk/pull/28208
More information about the serviceability-dev
mailing list