RFR: 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests [v3]
Leonid Mesnik
lmesnik at openjdk.org
Mon Dec 15 08:00:58 UTC 2025
On Mon, 15 Dec 2025 06:25:43 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>>
>> The DockerTestUtils.RETAIN_IMAGE_AFTER_TEST variable which read the property from "jdk.test.docker.retain.image" do not work for some of the docker tests, such as jdk/internal/platform/docker/TestDockerCpuMetrics.java, only works for some of the docker tests, such as jdk/internal/platform/docker/TestPidsLimit.java.
>>
>> This PR read the DockerTestUtils.RETAIN_IMAGE_AFTER_TEST inside function removeDockerImage instead of before all the fucntion removeDockerImage. This will make all the docker tests receive the property jdk.test.docker.retain.image.
>>
>> Change has been verified locally on linux-x64 by run the all touched tests.
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into jbs8371503
> - Remove extra ident
> - 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests
Marked as reviewed by lmesnik (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28208#pullrequestreview-3576911752
More information about the serviceability-dev
mailing list