RFR: 8374168: Resolve disabled warnings in JDWP agent [v3]
Alex Menkov
amenkov at openjdk.org
Tue Dec 23 02:33:34 UTC 2025
On Tue, 23 Dec 2025 01:52:32 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - copyright
>> - renamed define args
>> - fixed windows GHA build
>
> src/jdk.jdwp.agent/share/native/libjdwp/util.h line 64:
>
>> 62: /* To handle "format string is not a string literal" warning. */
>> 63: #if !defined(_MSC_VER)
>> 64: #define ATTRIBUTE_PRINTF(fmt_pos_num, vargs_pos_num) __attribute__((format(printf, fmt_pos_num, vargs_pos_num)))
>
> The line is kind of long now. Maybe start the definition on a new line.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28937#discussion_r2641743174
More information about the serviceability-dev
mailing list