RFR: 8374168: Resolve disabled warnings in JDWP agent [v4]

Alex Menkov amenkov at openjdk.org
Tue Dec 23 02:38:53 UTC 2025


On Tue, 23 Dec 2025 01:59:28 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   break long line
>
> src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c line 189:
> 
>> 187:                                         >> (int)JVMTI_VERSION_SHIFT_MINOR;
>> 188:     jvmtiCompileTimeMicroVersion  = ((int)JVMTI_VERSION & (int)JVMTI_VERSION_MASK_MICRO)
>> 189:                                         >> (int)JVMTI_VERSION_SHIFT_MICRO;
> 
> Can you explain the need for this. These types are all naturally jints, so I'm not sure why you would need to cast them here.

These are enums (i.e. ints) , GHA on Windows fail because they are 3 different enum types (warning 5287)
For unknown reason (different MSVC version maybe) my local Windows build and our CI passed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28937#discussion_r2641749094


More information about the serviceability-dev mailing list