RFR: 8319055: JCMD should not buffer the whole output of commands [v2]
Alex Menkov
amenkov at openjdk.org
Fri Feb 7 02:44:36 UTC 2025
On Thu, 6 Feb 2025 17:35:08 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> feedback
>
> test/hotspot/jtreg/serviceability/attach/AttachAPIv2/StreamingOutputTest.java line 86:
>
>> 84:
>> 85: private static void verify(boolean clientStreaming, boolean vmStreaming, String out) throws Exception {
>> 86: System.out.println("Target VM output:");
>
> Q: It is confusing that the boolean argument vmStreaming is not used. Would you like to get rid of it?
Added verification for expected value.
Also updated logging and verification of clientStreaming to not fail on AIX (AIX does not support streaming output yet as I don't have an environment to test it)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23405#discussion_r1945881941
More information about the serviceability-dev
mailing list