RFR: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal
    Daniel Fuchs 
    dfuchs at openjdk.org
       
    Tue Feb 11 16:47:14 UTC 2025
    
    
  
On Fri, 10 Jan 2025 14:43:00 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
> DescriptorSupport has a constructor and a method providing creation from, and export to, XML.
> 
> These are unused in the JDK and have no practical known examples of usage.  XML parsing is best done by an independent implementation, not this class.
src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java line 205:
> 203:      * @exception MBeanException Wraps a distributed communication Exception.
> 204:      * @deprecated This constructor exists for historical reasons.  It enables
> 205:      * reading from XML, which is unnecessary.
I wonder if we should say instead "Reading from XML if required should be implemented externally".
src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java line 975:
> 973:      * thrown.
> 974:      * @deprecated This method exists for historical reaons. It
> 975:      * enables writing as XML, which is unnecessary.
Same here: "Writing to XML, if required, should be implemented externally."
src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java line 1067:
> 1065:     }
> 1066: 
> 1067:     @SuppressWarnings("removal")
Can we add a comment to indicate that XMLParseException is deprecated for removal?
src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java line 1131:
> 1129:      * without the parentheses.
> 1130:      */
> 1131:     @SuppressWarnings("removal")
Can we add a comment to indicate that XMLParseException is deprecated for removal?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1951205306
PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1951207163
PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1951195117
PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1951200677
    
    
More information about the serviceability-dev
mailing list