RFR: 8349088: De-virtualize Codeblob and nmethod [v8]

[Chris Plummer]

On Thu, 13 Feb 2025 17:14:59 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Remove virtual methods from CodeBlob and nmethod to simplify saving/restoring in Leyden AOT cache. It avoids the need to patch hidden VPTR pointer to class's virtual table.
>> 
>> Added C++ static asserts to make sure no virtual methods are added in a future.
>> 
>> Fixed/cleaned SA code which process CodeBlob and its subclasses. Use `CodeBlob::_kind` field value to determine the type of blob.
>> 
>> Tested tier1-5, hs-tier6-rt (for JFR testing), stress, xcomp
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rename SA argument

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java line 97:

> 95:   // cbAddr - address of a code blob
> 96:   // cbPC   - address inside of a code blob
> 97:   public CodeBlob createCodeBlobWrapper(Address cbAddr, Address cbPC) {

Can you change findBlobUnsafe() above also? That's where the naming problem originated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23533#discussion_r1955098013