RFR: 8192647: GClocker induced GCs can starve threads requiring memory leading to OOME [v2]
Albert Mingkun Yang
ayang at openjdk.org
Sat Feb 15 11:52:14 UTC 2025
On Fri, 7 Feb 2025 06:43:25 GMT, David Holmes <dholmes at openjdk.org> wrote:
> But in any case adding the atomic load to in_critical() is basically a no-op (loads are atomic) so no need to add a new API just to do that.
I have removed the new API, and switched to use the original `in_critical()`.
> I think that to get the correct "dekker duality" in this code you do need to have full fences between the stores and loads, not just a storeload barrier.
I have changed to `fence` for simpler reasoning. (In our codebase, the two have the same implementation, so perf should be the same.)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23367#issuecomment-2660886740
More information about the serviceability-dev
mailing list