RFR: 8280682: Refactor AOT code source validation checks [v3]

[Calvin Cheung]

On Tue, 18 Feb 2025 07:22:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @ashu-mehra and @dholmes-ora comments
>
> src/hotspot/share/runtime/threads.cpp line 809:
> 
>> 807:     vm_exit_during_initialization("ClassLoader::initialize_module_path() failed unexpectedly");
>> 808:   }
>> 809: #endif
> 
> Not obvious where this functionality is now handled.

It is now being handled in `ClassLoaderDataShared::ensure_module_entry_tables_exist()` and `AOTCodeSourceConfig::dumptime_init_helper()`.

> test/hotspot/jtreg/runtime/cds/appcds/NonExistClasspath.java line 70:
> 
>> 68:             .assertNormalExit();
>> 69: 
>> 70:         // Now make nonExistPath exist. CDS will fail to load.
> 
> Not at all clearr why these test cases have been removed?

I've added back the removed test cases to ensure the handling of non-existent entries remains the same after refactoring.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1962468145
PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1962468453