RFR: 8280682: Refactor AOT code source validation checks [v4]

[Calvin Cheung]

On Thu, 20 Feb 2025 02:15:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> It is now being handled in `ClassLoaderDataShared::ensure_module_entry_tables_exist()` and `AOTCodeSourceConfig::dumptime_init_helper()`.
>
> I don't see anything there that does a vm_exit if something has gone wrong. ??

How about adding the vm_exit in `ClassLoaderDataShared::ensure_module_entry_table_exist()` instead of assert?


void ClassLoaderDataShared::ensure_module_entry_table_exist(oop class_loader) {
  Handle h_loader(JavaThread::current(), class_loader);
  ModuleEntryTable* met = Modules::get_module_entry_table(h_loader);
  if (met == nullptr) {
    vm_exit_during_initialization("ClassLoaderDataShared::ensure_module_entry_table_exist() failed unexpectedly");
  }
}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23476#discussion_r1962972927