RFR: 8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Feb 21 06:30:59 UTC 2025


On Thu, 13 Feb 2025 12:30:32 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> DescriptorSupport has a constructor and a method providing creation from, and export to, XML.
>> 
>> These are unused in the JDK and have no practical known examples of usage.  XML parsing is best done by an independent implementation, not this class.
>
> Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - comments
>  - Merge remote-tracking branch 'upstream/master' into 8347433_DescriptorSupport_deprecate_XML
>  - (c)
>  - typo
>  - Merge remote-tracking branch 'upstream/master' into 8347433_DescriptorSupport_deprecate_XML
>  - Also XMLParseException
>  - RMMB comment update
>  - Deprecate XML interchange in DescriptorSupport

This fix looks okay. Posted one question though.

src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java line 977:

> 975:      * construction fails for any reason, this exception will be
> 976:      * thrown.
> 977:      * @deprecated This constructor exists for historical reasons.  If

Q: This is not constructor, right?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23038#pullrequestreview-2632098127
PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1964914802


More information about the serviceability-dev mailing list