RFR: 8350571: Remove mention of Tonga test suite from JMX tests

[Leonid Mesnik]

On Mon, 24 Feb 2025 21:28:57 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> test/jdk/javax/management/MBeanServer/ExceptionTest.java line 227:
>> 
>>> 225:          * Reproduces the original parsing and collection of test parameters
>>> 226:          * from the DTonga JMX test suite.
>>> 227:          *
>> 
>> There are few similar methods
>>         static Map<String, Object> parseParameters(String args[])
>> in different Utils classes. 
>> Have you considered the removal of duplication code?
>> Also, the comment like 
>> " Reproduces the original parsing and collection of test parameters from legacy test suite"
>> might explain why this logic is needed. But it is up to you.
>
> Thanks -
> For the paseParameters(arg) method, I think if I remove the reference to the mysterious legacy test suite, there is nothing left in that line worth saying.
> 
> The comment goes on to say "Collects passed args and returns them in a map..etc..." which seems worthwhile.
> 
> There probably is much further tidyup that we can do here, yes maybe the methods are the same, and maybe so may "Utils" classes is not great.  But I just wanted to remove this one point of confusion today!

The link to legacy is a just good explanation why this method is realized in such way. Like note, "There is might be no logic in this method, just legacy."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23747#discussion_r1968448707