RFR: 8315488: SA ciReplay support is no longer up-to-date with hotspot ciReplay support [v6]

Coleen Phillimore coleenp at openjdk.org
Fri Feb 28 15:59:10 UTC 2025


On Fri, 28 Feb 2025 01:01:48 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove VM_STRUCTS macro arguments.
>
> src/jdk.hotspot.agent/doc/index.html line 43:
> 
>> 41: </p>
>> 42: 
>> 43: <h3>Compilation Replay</h3>
> 
> clhsdb.html also needs to be updated.

Fixed.

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/CompilerThread.java line 48:
> 
>> 46:   private static synchronized void initialize(TypeDataBase db) throws WrongTypeException {
>> 47:     Type type      = db.lookupType("CompilerThread");
>> 48: 
> 
> Line 47 above is no longer needed.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23782#discussion_r1975626044
PR Review Comment: https://git.openjdk.org/jdk/pull/23782#discussion_r1975630237


More information about the serviceability-dev mailing list