RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v16]

Sergey Chernyshev schernyshev at openjdk.org
Fri Feb 28 20:47:08 UTC 2025


On Fri, 28 Feb 2025 12:27:13 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Sergey Chernyshev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updated comment
>
> test/jdk/jdk/internal/platform/cgroup/CgroupV1SubsystemControllerTest.java line 69:
> 
>> 67:     /*
>> 68:      * Less common cases: Containers
>> 69:      */
> 
> Not really sure why this comment was added, is it refering to 'container mode'  mentioned in the comment above in another file?

It's because there are already "Common case: Containers" and "Common case: Host". The old test testCgPathSubstring() and the new test testCgPathToMovedPath() do not belong to "Common case: Host" that comes just before them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21808#discussion_r1975991035


More information about the serviceability-dev mailing list