RFR: 8339113: AccessFlags can be u2 in metadata [v5]
Coleen Phillimore
coleenp at openjdk.org
Thu Jan 2 12:37:39 UTC 2025
On Wed, 25 Dec 2024 16:34:27 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> It wasn't the logic. When I went through I didn't know if this instruction needed fixing because we loaded an unsigned short instead of an int. So I left myself a note to look at it again that you noticed and I didn't in my final walk through. It seems right but maybe someone with ppc knowledge can answer this.
>>
>>
>> rldicl_(R0, Raccess_flags, 64-JVM_ACC_SYNCHRONIZED_BIT, 63); // Extract bit and compare to 0.
>
> The instruction looks still correct. We are checking the same bit of the 64 bit register as before. (Using `testbitdi` would also work.)
I changed this to testbitdi.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1900836026
More information about the serviceability-dev
mailing list