RFR: 8339113: AccessFlags can be u2 in metadata [v11]

Coleen Phillimore coleenp at openjdk.org
Mon Jan 6 13:46:40 UTC 2025


On Mon, 6 Jan 2025 03:44:09 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix more copyrights.
>
> src/hotspot/share/ci/ciFlags.cpp line 95:
> 
>> 93: // ciFlags::print
>> 94: void ciFlags::print(outputStream* st) {
>> 95:   st->print(" flags=%x", _flags.as_unsigned_short());
> 
> Here, and elsewhere, are we relying on an implicit widening of the u2 result to int so that the format specifier is correct?

Yes, we are.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1904168828


More information about the serviceability-dev mailing list