RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v2]

Coleen Phillimore coleenp at openjdk.org
Mon Jan 6 16:02:36 UTC 2025


On Sat, 4 Jan 2025 09:52:00 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix %Ix to %zx.
>
> test/hotspot/gtest/utilities/test_globalDefinitions.cpp line 281:
> 
>> 279: 
>> 280:   check_format("%zd",                  (intx)123,         "123");
>> 281:   check_format("0x%zx",                (intx)0x123,       "0x123");
> 
> Could be "%#zx".

I fixed this.  This seems ok.  I didn't know about this format option tbh but if it's standard, why not?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22916#discussion_r1904331779


More information about the serviceability-dev mailing list