RFR: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE [v5]

Serguei Spitsyn sspitsyn at openjdk.org
Tue Jan 7 19:39:26 UTC 2025


> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the specified FramePop event was already requested. This makes it consistent with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt to add a breakpoint request that was already requested.
> 
> CSR: [8346460](https://bugs.openjdk.org/browse/JDK-8346460): NotifyFramePop should return JVMTI_ERROR_DUPLICATE
> 
> Testing:
>  - tested with mach5 tiers 1-6

Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge
 - review: improved one failure logging a little bit
 - review: added NotifyFramePop test case to check JVMTI_ERROR_DUPLICATE is returned
 - review: minor tweak in jvmti.xml update
 - 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22798/files
  - new: https://git.openjdk.org/jdk/pull/22798/files/2b3fef1e..2468357f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22798&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22798&range=03-04

  Stats: 21029 lines in 649 files changed: 15125 ins; 3706 del; 2198 mod
  Patch: https://git.openjdk.org/jdk/pull/22798.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22798/head:pull/22798

PR: https://git.openjdk.org/jdk/pull/22798


More information about the serviceability-dev mailing list