RFR: 8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests
David Holmes
dholmes at openjdk.org
Wed Jan 8 05:54:36 UTC 2025
On Tue, 7 Jan 2025 07:58:18 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:
> Trivial logging message change.
Changes requested by dholmes (Reviewer).
test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001.java line 2:
> 1: /*
> 2: * Copyright (c) 2007, 2024, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2007, 2025, Oracle and/or its affiliates. All rights reserved.
test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001.java line 65:
> 63: }
> 64:
> 65: System.out.println("Can't reproduce OOME due to a limit on iterations/execution time. resexhausted001 Test was useless."
Suggestion:
System.out.println("Test resexhausted001: Can't reproduce OOME due to a limit on iterations/execution time. Test was useless."
This format reads somewhat better to me.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22939#pullrequestreview-2536062199
PR Review Comment: https://git.openjdk.org/jdk/pull/22939#discussion_r1906510965
PR Review Comment: https://git.openjdk.org/jdk/pull/22939#discussion_r1906512847
More information about the serviceability-dev
mailing list