Integrated: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller

[Patricio Chilano Mateo]

On Mon, 6 Jan 2025 16:41:21 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Please review the following fix. In method `JvmtiEventControllerPrivate::recompute_thread_enabled()`, we are missing to call `leave_interp_only_mode()` for the case where `should_be_interp` is computed as false and `state->is_pending_interp_only_mode()` is true. I added the full trace leading to the crash in the bug comments.
> In JDK-8338383 I removed this assert because the branch condition changed and it became sort of a redundant check. But given that it was able to find this issue I added it back.
> I was able to reproduce the crash easily by adding an extra delay before the assert. I verified the crash doesn’t reproduce anymore with this fix. I also run the patch through mach5 tiers 1-7.
> 
> Thanks,
> Patricio

This pull request has now been integrated.

Changeset: ea495377
Author:    Patricio Chilano Mateo <pchilanomate at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ea49537726db6530f0ddcc04d9938df3d6d18250
Stats:     2 lines in 2 files changed: 1 ins; 0 del; 1 mod

8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller

Reviewed-by: dholmes, amenkov, sspitsyn

-------------

PR: https://git.openjdk.org/jdk/pull/22931