RFR: 8347733: Replace SIZE_FORMAT in runtime code [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Fri Jan 17 15:02:41 UTC 2025
On Fri, 17 Jan 2025 12:18:52 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Please review this change to replace SIZE_FORMAT with %zu in the runtime code. The second and third commits are hand editing for fixing up formats of the code, not the output. After this, there'll be a separate change to remove SIZE_FORMAT. Note that SIZE_FORMAT_X_0 depends on LP64 so that macro will be retained. There were a couple of compiler files that I missed.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Added the needed blank.
Changes look good!
src/hotspot/share/utilities/globalDefinitions.hpp line 137:
> 135: #define UINT64_FORMAT_0 "%016" PRIx64
> 136:
> 137:
Extra newline added here, was that on purpose?
-------------
Marked as reviewed by matsaave (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23160#pullrequestreview-2559235603
PR Review Comment: https://git.openjdk.org/jdk/pull/23160#discussion_r1920318853
More information about the serviceability-dev
mailing list