RFR: 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed [v2]
Leonid Mesnik
lmesnik at openjdk.org
Fri Jan 17 20:10:36 UTC 2025
On Fri, 17 Jan 2025 02:09:54 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> The test lacks a synchronization, so it is added by this fix.
>>
>> Testing:
>> - Ran the failing test `vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002`
>> - TBD: submit mach5 tiers 1-5
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>
> review: add a clarifying comment to monitor declaration
It is a good improvement of test stability. However, I am not sure that it fixed test problem.
Can the test fails because clock on the host were changed? There are some similar test failures happened when host update clock time during test execution.
-------------
Marked as reviewed by lmesnik (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23144#pullrequestreview-2559877062
More information about the serviceability-dev
mailing list