RFR: 8229012: When single stepping, the debug agent can cause the thread to remain in interpreter mode after single stepping completes [v2]

[Chris Plummer]

On Wed, 22 Jan 2025 07:27:48 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some minor cleanup.
>
> src/jdk.jdwp.agent/share/native/libjdwp/stepControl.c line 940:
> 
>> 938: 
>> 939:         if (needsSuspending) {
>> 940:             tty_message("clearStep: resuming thread");
> 
> Q: Lines: 913, 940. Should such a message printing be under the `#ifdef DEBUG` ?

Removed.

> test/jdk/com/sun/jdi/SingleStepCompilationTest.java line 30:
> 
>> 28:  * @bug 8229012
>> 29:  * @summary Verify that during single stepping a method is not compiled and
>> 30:  *          after single stepping it is compiled..
> 
> Nit: The dots are not needed at the end.

Fixed

> test/jdk/com/sun/jdi/SingleStepCompilationTest.java line 32:
> 
>> 30:  *          after single stepping it is compiled..
>> 31:  * @requires vm.compMode == "Xmixed"
>> 32:  * @library /test/lib /
> 
> Q: Just want to make sure the`/` at the end is not a typo. :)

Fixed. Probably I didn't fully delete a 2nd path that was copied from some other test.

> test/jdk/com/sun/jdi/SingleStepCompilationTest.java line 228:
> 
>> 226:         /*
>> 227:          * Deal with results of test. If anything has called failure("foo")
>> 228:          * then testFailed will be true
> 
> Nit: Need dots at the end of lines: 200, 207 and 228.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23182#discussion_r1926037982
PR Review Comment: https://git.openjdk.org/jdk/pull/23182#discussion_r1926038250
PR Review Comment: https://git.openjdk.org/jdk/pull/23182#discussion_r1927306989
PR Review Comment: https://git.openjdk.org/jdk/pull/23182#discussion_r1927299777