RFR: 8284016: Normalize handshake closure names [v3]

[Anton Artemov]

On Tue, 1 Jul 2025 08:46:37 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8284016: Reverted closure names in JVMTI
>
> src/hotspot/share/classfile/javaClasses.cpp line 1980:
> 
>> 1978:   ResourceMark rm(THREAD);
>> 1979:   HandleMark   hm(THREAD);
>> 1980:   GetStackTraceHandshakeClosure gstc(Handle(THREAD, java_thread));
> 
> Nit: A suggestion to rename: `gstc` => `gsthc` or `gstc` => `hc` or `gstc` => `cl`.

Thanks, makes sense, addressed in the latest commit.

> src/hotspot/share/prims/whitebox.cpp line 2288:
> 
>> 2286:   };
>> 2287: 
>> 2288:   ReadMonitorsHandshakeClosure rmc;
> 
> Nit: A suggestion to rename: `rmc` => `rmhc` or `rmc` => `cl`.

Thanks, makes sense, addressed in the latest commit.

> src/hotspot/share/prims/whitebox.cpp line 2357:
> 
>> 2355:     bool is_alive = tlh.cv_internal_thread_to_JavaThread(thread_handle, &target, nullptr);
>> 2356:     if (is_alive) {
>> 2357:       TraceSelfHandshakeClosure* tsc = new TraceSelfHandshakeClosure(target);
> 
> Nit: A suggestion to rename: `tsc` => `tshc` or `tsc` => `cl`.

Thanks, makes sense, addressed in the latest commit.

> src/hotspot/share/runtime/vmThread.cpp line 456:
> 
>> 454:       if (HandshakeALot) {
>> 455:         MutexUnlocker mul(VMOperation_lock);
>> 456:         ALotOfHandshakeClosure hal_cl;
> 
> Nit: Rename: `hal_cl` => `aohc` or `hfd_hc` => `cl`.

Thanks, makes sense, addressed in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2177016990
PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2177017247
PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2177017485
PR Review Comment: https://git.openjdk.org/jdk/pull/26014#discussion_r2177017688