RFR: 8284016: Normalize handshake closure names [v4]
Coleen Phillimore
coleenp at openjdk.org
Tue Jul 1 11:23:45 UTC 2025
On Tue, 1 Jul 2025 09:39:22 GMT, Anton Artemov <duke at openjdk.org> wrote:
>> Hi, please consider the following changes:
>>
>> There are many classes inherited from the `HandshakeClosure` class, but they do not follow the same naming convention. In this PR we address this issue, all names are normalized in the following way:
>>
>> `XXXDummyClassNameClosure -> XXXDummyClassNameHandshakeClosure`
>>
>> or
>>
>> `XXXDummyClassNameHandshake -> XXXDummyClassNameHandshakeClosure`
>>
>> or
>>
>> `XXXStrangeClassName -> SomewhatSimilarNameHandshakeClosure`
>>
>> Tested in GHA and tiers 1 - 3.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8284016: Addressed reviewer's comments
Still looks good. So the pattern is that something that inherits directly from HandshakeClosure is TheThingHandshakeClosure and in the case of JVMTI further inheritance has a shorter name. Seems fine. So many handshakes!
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26014#pullrequestreview-2974982990
More information about the serviceability-dev
mailing list