RFR: 8361292: Rename ModuleEntry::module() to module_oop() [v2]
Ioi Lam
iklam at openjdk.org
Wed Jul 2 18:14:57 UTC 2025
> A module has both a Java and a C++ representation
>
> - C++: `ModuleEntry`
> - Java: `java.lang.Module`
>
> In C++, we have the following two methods
>
> - `ModuleEntry* InstanceKlass::module()`
> - `oop ModuleEntry::module()`
>
> This can lead to confusing code like this:
>
>
> InstanceKlass* ik = ...;
> oop module = ik->module()->module()
>
>
> Proposal:
>
> - Leave `InstanceKlass::module()` as is -- there's another function with the same style: `PackageEntry* InstanceKlass::package()`
> - Rename `ModuleEntry::module()` to `ModuleEntry::module_oop()`, so the above example can be more readable:
>
>
> InstanceKlass* ik = ...;
> oop module = ik->module()->module_oop()
Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
@coleenp comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26102/files
- new: https://git.openjdk.org/jdk/pull/26102/files/69b453e2..f58f2852
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26102&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26102&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/26102.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26102/head:pull/26102
PR: https://git.openjdk.org/jdk/pull/26102
More information about the serviceability-dev
mailing list