RFR: 8355960: JvmtiAgentList::Iterator dtor double free with -fno-elide-constructors [v2]
Alex Menkov
amenkov at openjdk.org
Thu Jul 3 01:17:56 UTC 2025
> Currently jvmtiAgentList keeps agents in reversed order (new agents are added to the head of the list).
> To restore original order JvmtiAgentList::Iterator uses GrowableArray allocated in heap.
> Iterators for different agent types are returned by value, and the iterator class nas no custom copy ctor, so if the constructor not elides, GrowableArray is deallocated twice.
>
> The fix updates jvmtiAgentList to keep agents in the original order, agents are added to the tail.
> Iterator now needs only single pointer to next agent.
> Additionally removed `JvmtiAgentList::Iterator::next() const` method (it looks very strange as `next()` is expected to change state of the iterator).
>
> Testing: tier1..4,hs-tier5-svc
Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
update
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26083/files
- new: https://git.openjdk.org/jdk/pull/26083/files/c93b598f..994ffddc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26083&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26083&range=00-01
Stats: 22 lines in 3 files changed: 1 ins; 5 del; 16 mod
Patch: https://git.openjdk.org/jdk/pull/26083.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26083/head:pull/26083
PR: https://git.openjdk.org/jdk/pull/26083
More information about the serviceability-dev
mailing list