RFR: 8361325: Refactor ClassLoaderExt [v2]

Calvin Cheung ccheung at openjdk.org
Thu Jul 3 17:12:56 UTC 2025


On Thu, 3 Jul 2025 12:56:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @coleenp comment
>
> src/hotspot/share/classfile/modules.cpp line 671:
> 
>> 669:   // list[3] = ""
>> 670:   // list[4] = ""
>> 671:   list.sort(Modules::compare_module_names);
> 
> Does compare _module_names have to be an external function?

I've changed it to a static function in modules.cpp.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26110#discussion_r2183286022


More information about the serviceability-dev mailing list