RFR: 8305567: serviceability/tmtools/jstat/GcTest01.java failed utils.JstatGcResults.assertConsistency [v2]

[Kevin Walls]

On Thu, 3 Jul 2025 16:51:34 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   modifier order
>
> test/hotspot/jtreg/serviceability/tmtools/jstat/utils/JstatTool.java line 46:
> 
>> 44:         for (int i = 1; i <= TRIES; i++) {
>> 45:             try {
>> 46:                 results = measure();
> 
> Might be the 'measure' and 'assertConsistency' might be changed to from 'public' to 'package-local` if they are not needed to be used by tests directly.

Thanks -

I left GarbageProducerTest with individual calls to measure() and assertConsistency().
This could be a small window for the same problem again.  It's not one where I think we have ever seen the problem before.
But it looks like that test's run() method tries to avoid a problem already, it tests if a collection has NOT happened during gathering, and only calls assertConsistency() if that's the case.

But I will update additionally to put a couple of modifiers in the traditional blessed order.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26094#discussion_r2189438383