RFR: 8361325: Refactor ClassLoaderExt [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Mon Jul 7 18:43:48 UTC 2025
On Thu, 3 Jul 2025 17:08:44 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> src/hotspot/share/cds/classListParser.cpp line 33:
>>
>>> 31: #include "cds/metaspaceShared.hpp"
>>> 32: #include "cds/unregisteredClasses.hpp"
>>> 33: #include "classfile/classLoader.hpp"
>>
>> Nit: I wonder if the line #33 is really needed and can be removed.
>
> It is needed or else I got compilation error:
>
> open/src/hotspot/share/cds/classListParser.cpp:561:29: error: 'ClassLoader' has not been declared
> 561 | const char* source_path = ClassLoader::uri_to_path(_source);
> | ^~~~~~~~~~~
>
> It worked before because classLoaderExt.hpp includes classLoader.hpp.
Okay, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26110#discussion_r2190802836
More information about the serviceability-dev
mailing list