RFR: 8359809: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object [v5]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Jul 10 15:08:44 UTC 2025
On Thu, 10 Jul 2025 08:08:35 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> test/jdk/javax/management/generified/ListTypeCheckTest.java line 110:
>>
>>> 108: throw new Exception("test wrong");
>>> 109: }
>>> 110: throw new Exception("op " + i + " allowed but should fail on " + al.getClass());
>>
>> Nit: This is confusing. If it is allowed then why should it fail.
>> At least, it needs to be explained somewhere in the tests.
>
> Thanks Serguei, I hope I've addressed both comments with additional comment updates.
Thank you for the update, Kevin!
I've almost done with reviewing but want to make one more pass, especially though the updated tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25856#discussion_r2198004375
More information about the serviceability-dev
mailing list