RFR: 8361602: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java deadlocks on exception [v3]

[David Holmes]

On Thu, 10 Jul 2025 10:02:56 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> This pr moves the `notify()` call to the finally block to avoid the deadlock in `join()` if `verifyHeapDump(dumpFile)` throws an exception.
>> 
>> Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.
>
> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Wait while !done

Thanks for update.

Still not sure that forcing the join is necessarily desirable if there is an unexpected exception, but ...

test/hotspot/jtreg/serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java line 50:

> 48: public class UnmountedVThreadNativeMethodAtTop {
> 49: 
> 50:     public boolean done;

Should not be public

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26213#pullrequestreview-3007594415
PR Review Comment: https://git.openjdk.org/jdk/pull/26213#discussion_r2198886549