RFR: 8362611: [GCC static analyzer] memory leak in ps_core.c core_handle_note [v2]

Lei Zhu duke at openjdk.org
Mon Jul 21 10:17:31 UTC 2025


On Mon, 21 Jul 2025 07:31:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Lei Zhu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   goto err
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 290:
> 
>> 288:           print_error("failed to handle NT_PRSTATUS note\n");
>> 289:           free(buf);
>> 290:           return false;
> 
> That works, but seems to me that, following the style of the code above, these two lines should be replaced by `goto err;`

Thanks for your review, the code has been corrected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26403#discussion_r2218745625


More information about the serviceability-dev mailing list